LGTM. 1 nit.
https://codereview.chromium.org/25655004/diff/3001/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/25655004/diff/3001/src/heap-inl.h#newcode529
src/heap-inl.h:529:
AllocationSite::CanTrack(object->map()->instance_type()) &&
See my other comment about CanTrack().
https://codereview.chromium.org/25655004/diff/3001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/25655004/diff/3001/src/mark-compact.cc#newcode2013
src/mark-compact.cc:2013:
AllocationSite::CanTrack(object->map()->instance_type()) &&
The CanTrack might be redundant because by offering the method
FindForJSObject on AllocationMemento class we are implicitly admitting
that AllocationMementos can track JSObjects.
Therefore the only thing we care about is that the object is a JSObject.
https://codereview.chromium.org/25655004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
