On 2013/10/02 09:53:53, Yang wrote:
LGTM with comments.

If you plan to add more of those flags, it would be cleaner to use one unified
flag.

yeah right i'll do that on the next flag i come up with :)

https://codereview.chromium.org/25693003/diff/2001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):


https://codereview.chromium.org/25693003/diff/2001/src/code-stubs-hydrogen.cc#newcode306
src/code-stubs-hydrogen.cc:306: timer.Start();
You don't want to include GenerateLightweightMissCode?

no, this is practically free, since its not using hydrogen but just the macro
assembler



https://codereview.chromium.org/25693003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to