LGTM, minor nits.
https://codereview.chromium.org/25009003/diff/7001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/25009003/diff/7001/src/hydrogen.cc#newcode8304
src/hydrogen.cc:8304: } else if (combined_type->NumClasses() == 1 &&
fits in one line
https://codereview.chromium.org/25009003/diff/7001/src/hydrogen.cc#newcode8314
src/hydrogen.cc:8314: } else if (combined_type->Is(Type::Receiver()) &&
fits in one line
https://codereview.chromium.org/25009003/diff/7001/test/mjsunit/compare-objects-fast.js
File test/mjsunit/compare-objects-fast.js (right):
https://codereview.chromium.org/25009003/diff/7001/test/mjsunit/compare-objects-fast.js#newcode31
test/mjsunit/compare-objects-fast.js:31: // objects in slow mode. These
objects share the same map even though they
in fast mode?
https://codereview.chromium.org/25009003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
