https://codereview.chromium.org/25722002/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/25722002/diff/1/src/types.cc#newcode134
src/types.cc:134: if (value->ToInt32(&i)) return kOtherSigned32;
On 2013/10/02 13:35:06, Jakob wrote:
How about:
if (value->ToInt32(&i)) {
if (Smi::IsValid(i)) return kSmi;
return kOtherSigned32;
}
Hm, right, there might be smis denormalised into heap numbers.
https://codereview.chromium.org/25722002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
