LGTM, rubber-stamped the first patch set and looked at the deltas, one
comment
to address.
https://codereview.chromium.org/25494007/diff/58001/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/25494007/diff/58001/src/code-stubs.cc#newcode296
src/code-stubs.cc:296: // Generated list of commonly used stubs
OMG, that is some humongous list you have there. We really should have
most of the stubs in the snapshot as before. I can be convinced to have
this as a temporary solution until we figure out why increasing the
snapshot size tanks things so much. Please leave a TODO here about that
and please alpha-sort this list.
https://codereview.chromium.org/25494007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
