LGTM if comments are addressed.
https://codereview.chromium.org/25669004/diff/4001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/25669004/diff/4001/src/objects.cc#newcode12964
src/objects.cc:12964: Handle<JSObject> holder,
nit: s/holder/object/ for consistency.
https://codereview.chromium.org/25669004/diff/4001/src/objects.cc#newcode12982
src/objects.cc:12982: RETURN_HANDLE_IF_SCHEDULED_EXCEPTION(isolate,
Object);
This check should be obsolete, if there is a scheduled excepten, then
"result" should already contain the empty handle. Let's drop it.
https://codereview.chromium.org/25669004/diff/4001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/25669004/diff/4001/src/objects.h#newcode2252
src/objects.h:2252: Handle<JSObject> holder,
nit: s/holder/object/ for consistency.
https://codereview.chromium.org/25669004/diff/4001/src/objects.h#newcode2257
src/objects.h:2257: Handle<JSObject> holder,
nit: s/holder/object/ for consistency.
https://codereview.chromium.org/25669004/diff/4001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/25669004/diff/4001/src/stub-cache.cc#newcode1285
src/stub-cache.cc:1285: return handle(*result, isolate);
I would keep the surrounding handle scope in line 1276, that makes sure
the API function gets a fresh handle scope. Doing "return
scope.CloseAndEscape(result);" here should implicitly take care of
reboxing the handle in the surrounding scope.
https://codereview.chromium.org/25669004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
