On 2013/10/02 18:20:03, Hannes Payer wrote:
https://codereview.chromium.org/22852024/diff/84001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/22852024/diff/84001/src/heap.cc#newcode4979
src/heap.cc:4979: HeapProfiler* profiler = isolate()->heap_profiler();
On 2013/10/02 18:00:29, Hannes Payer wrote:
> Why do you track the allocation of the memento separately? And why
don't you
> account the allocation in the if branch before?
Ok, ignore question two, because you allocate using AllocateRaw. But why
do
you
track the memento separately?
Hi Hannes,
Thanks for your feedback. I've made some corrections.
Allocation of several objects in one go may be a problem as there appear
untracked allocations. For example, if both objects A and B are allocated
in one
go (and B goes right after A), we will have A tracked with the wrong size
(sizeof(A, B)) and B untracked. The size of A may be adjusted later during
migration, but B will still remain untracked.
We try to mind such situations. A good example is allocation of an object
and an
allocation memento together
(https://codereview.chromium.org/22852024/diff/84001/src/heap.cc). After the
allocation itself, we adjust the object size and track the memento.
https://codereview.chromium.org/22852024/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
