Revision: 17107
Author: [email protected]
Date: Fri Oct 4 11:57:42 2013 UTC
Log: Explicitly include defaults.cc in the shared_library gyp target.
Explicitly include defaults.cc in the shared_library gyp target, otherwise
the whole compilation unit is stripped by the Windows linker, since none of
it's
symbols are referenced by any other compilation unit in V8.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/25994002
Patch from Ross McIlroy <[email protected]>.
http://code.google.com/p/v8/source/detail?r=17107
Modified:
/branches/bleeding_edge/src/defaults.cc
/branches/bleeding_edge/tools/gyp/v8.gyp
=======================================
--- /branches/bleeding_edge/src/defaults.cc Wed Oct 2 13:36:38 2013 UTC
+++ /branches/bleeding_edge/src/defaults.cc Fri Oct 4 11:57:42 2013 UTC
@@ -25,6 +25,9 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+// The GYP based build ends up defining USING_V8_SHARED when compiling this
+// file.
+#undef USING_V8_SHARED
#include "../include/v8-defaults.h"
#include "platform.h"
=======================================
--- /branches/bleeding_edge/tools/gyp/v8.gyp Wed Oct 2 11:43:41 2013 UTC
+++ /branches/bleeding_edge/tools/gyp/v8.gyp Fri Oct 4 11:57:42 2013 UTC
@@ -61,6 +61,10 @@
# Note: on non-Windows we still build this file so that gyp
# has some sources to link into the component.
'../../src/v8dll-main.cc',
+ '../../src/defaults.cc',
+ ],
+ 'include_dirs': [
+ '../../include',
],
'defines': [
'V8_SHARED',
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
