I wanted to test non-UTC time zone for better code coverage.
Also, this is February so we shouldn't have failures due to the DST changes.
I'll keep non-UTC methods in those files.
On 2013/10/08 20:04:40, mnita wrote:
lgtm
Two files use non-UTC methods to access date fields.
Nothing wrong, but probably nicer to be consistent.
https://codereview.chromium.org/25855005/diff/3001/test/intl/date-format/parse-MMMdy.js
File test/intl/date-format/parse-MMMdy.js (right):
https://codereview.chromium.org/25855005/diff/3001/test/intl/date-format/parse-MMMdy.js#newcode40
test/intl/date-format/parse-MMMdy.js:40: assertEquals(1974,
date.getFullYear());
Should we go with UTC fields, for consistency?
https://codereview.chromium.org/25855005/diff/3001/test/intl/date-format/parse-mdy.js
File test/intl/date-format/parse-mdy.js (right):
https://codereview.chromium.org/25855005/diff/3001/test/intl/date-format/parse-mdy.js#newcode31
test/intl/date-format/parse-mdy.js:31: assertEquals(1974,
date.getFullYear());
Should we go with UTC fields, for consistency?
https://codereview.chromium.org/25855005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
