https://codereview.chromium.org/25505002/diff/1/src/optimizing-compiler-thread.h
File src/optimizing-compiler-thread.h (right):
https://codereview.chromium.org/25505002/diff/1/src/optimizing-compiler-thread.h#newcode55
src/optimizing-compiler-thread.h:55: input_queue_semaphore_(0),
The external synchronization on these buffers is starting to be a drag.
Now that we are using mutexes again, can we please encapsulate the
synchronization into the buffers somehow?
https://codereview.chromium.org/25505002/diff/1/src/optimizing-compiler-thread.h#newcode79
src/optimizing-compiler-thread.h:79: inline void DrainOsrBuffer() {
I like the idea of dropping one OSR entry per GC, but this method could
use a better name. "Drain" to me implies that it empties the entire
buffer.
https://codereview.chromium.org/25505002/diff/1/src/utils.h
File src/utils.h (right):
https://codereview.chromium.org/25505002/diff/1/src/utils.h#newcode1144
src/utils.h:1144: class CircularBuffer {
This class needs some unit tests.
https://codereview.chromium.org/25505002/diff/1/src/utils.h#newcode1199
src/utils.h:1199: class CircularQueue {
And this one too.
https://codereview.chromium.org/25505002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
