On 2013/10/10 13:00:44, Michael Starzinger wrote:
LGTM with a couple of minor comments.
https://codereview.chromium.org/25254002/diff/5001/src/hydrogen-flow-engine.h
File src/hydrogen-flow-engine.h (right):
https://codereview.chromium.org/25254002/diff/5001/src/hydrogen-flow-engine.h#newcode48
src/hydrogen-flow-engine.h:48: // do nothing.
If Disabled() returns true above, none of these methods should actually be
called. Could be add an UNREACHABLE macro instead of the "do nothing"
comment?
In such a situation it's harmless, so I usually wouldn't want to hardwire
it to
break.
https://codereview.chromium.org/25254002/diff/5001/src/hydrogen-flow-engine.h#newcode50
src/hydrogen-flow-engine.h:50: inline void Process(HValue* value, Zone*
zone)
{
I think the value here should be an HInstruction as Phis cannot be
processed
as
part of a state IIUC.
https://codereview.chromium.org/25254002/diff/5001/src/hydrogen-flow-engine.h#newcode51
src/hydrogen-flow-engine.h:51: // do nothing.
Likewise.
https://codereview.chromium.org/25254002/diff/5001/src/hydrogen-flow-engine.h#newcode54
src/hydrogen-flow-engine.h:54: // do nothing.
Likewise.
https://codereview.chromium.org/25254002/diff/5001/src/hydrogen-flow-engine.h#newcode65
src/hydrogen-flow-engine.h:65: inline NoState* Process(HValue* value,
Zone*
zone) {
I think the value here should be an HInstruction as Phis cannot be
processed
as
part of a state IIUC.
Done.
https://codereview.chromium.org/25254002/diff/5001/src/hydrogen-flow-engine.h#newcode109
src/hydrogen-flow-engine.h:109: if (new_state != state) SetStateAt(block,
new_state);
Should we really update the state for each block here? IIUC the
block_states
list keeps the state at the block entry for each block, so we shouldn't
update
it as we go through the instructions inside a block.
Good point. Done.
https://codereview.chromium.org/25254002/diff/5001/src/hydrogen-flow-engine.h#newcode139
src/hydrogen-flow-engine.h:139: if (new_state != state) SetStateAt(block,
new_state);
See comment above.
Yep.
https://codereview.chromium.org/25254002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
