Revision: 17175
Author:   [email protected]
Date:     Mon Oct 14 08:03:35 2013 UTC
Log:      HIsStringAndBranch does an implicit SMI check if necessary.

No need to test for SMI first using HIsSmiAndBranch.

[email protected]

Review URL: https://codereview.chromium.org/27160002
http://code.google.com/p/v8/source/detail?r=17175

Modified:
 /branches/bleeding_edge/src/code-stubs-hydrogen.cc

=======================================
--- /branches/bleeding_edge/src/code-stubs-hydrogen.cc Fri Oct 11 09:25:14 2013 UTC +++ /branches/bleeding_edge/src/code-stubs-hydrogen.cc Mon Oct 14 08:03:35 2013 UTC
@@ -885,8 +885,7 @@
     // critical.
     if (left_type->Maybe(Type::String())) {
       IfBuilder left_string(this);
-      left_string.IfNot<HIsSmiAndBranch>(left);
-      left_string.AndIf<HIsStringAndBranch>(left);
+      left_string.If<HIsStringAndBranch>(left);
       left_string.Then();
       Push(Add<HStringAdd>(left, right, STRING_ADD_CHECK_RIGHT));
       left_string.Else();
@@ -897,8 +896,7 @@
       result = Pop();
     } else {
       IfBuilder right_string(this);
-      right_string.IfNot<HIsSmiAndBranch>(right);
-      right_string.AndIf<HIsStringAndBranch>(right);
+      right_string.If<HIsStringAndBranch>(right);
       right_string.Then();
       Push(Add<HStringAdd>(left, right, STRING_ADD_CHECK_LEFT));
       right_string.Else();

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to