Revision: 17182
Author: [email protected]
Date: Mon Oct 14 09:22:34 2013 UTC
Log: Drop useless HForceRepresentation in BinaryOpStub.
[email protected]
Review URL: https://codereview.chromium.org/27167002
http://code.google.com/p/v8/source/detail?r=17182
Modified:
/branches/bleeding_edge/src/code-stubs-hydrogen.cc
=======================================
--- /branches/bleeding_edge/src/code-stubs-hydrogen.cc Mon Oct 14 08:03:35
2013 UTC
+++ /branches/bleeding_edge/src/code-stubs-hydrogen.cc Mon Oct 14 09:22:34
2013 UTC
@@ -932,17 +932,15 @@
result = EnforceNumberType(result, result_type);
}
- // Reuse the double box if we are allowed to (i.e. chained binops).
+ // Reuse the double box of one of the operands if we are allowed to (i.e.
+ // chained binops).
if (stub->CanReuseDoubleBox()) {
- HValue* reuse = (stub->mode() == OVERWRITE_LEFT) ? left : right;
+ HValue* operand = (stub->mode() == OVERWRITE_LEFT) ? left : right;
IfBuilder if_heap_number(this);
- if_heap_number.IfNot<HIsSmiAndBranch>(reuse);
+ if_heap_number.IfNot<HIsSmiAndBranch>(operand);
if_heap_number.Then();
- HValue* res_val = Add<HForceRepresentation>(result,
- Representation::Double());
- HObjectAccess access = HObjectAccess::ForHeapNumberValue();
- Add<HStoreNamedField>(reuse, access, res_val);
- Push(reuse);
+ Add<HStoreNamedField>(operand, HObjectAccess::ForHeapNumberValue(),
result);
+ Push(operand);
if_heap_number.Else();
Push(result);
if_heap_number.End();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
