I think we should reconsider the whole test, and especially this CL. With a
running time of more than 8 seconds on a HP 620 it is by far the longest
running
test in release mode. Note that it only takes 24 seconds for all
ia32.release.check with -j32. Funnily enough, we take *less* time in debug
mode,
no clue why:
-------------------------------------------------------------------------------------------
svenpanne@svenpanne[master]:~/v8$ tools/run-tests.py --outdir=out
--arch=ia32
--time mjsunit/regress/regress-embedded-cons-string
running presubmit tests
Running C++ lint check...
No changes in files detected. Skipping cpplint check.
Running copyright header, trailing whitespaces and two empty lines between
declarations check...
Total violating files: 0
Running tests for ia32.release
No connection to distribution server; running tests locally.
[00:08|% 100|+ 3|- 0]: Done
--- Total time: 00:08.644 ---
1 (00:08.625) mjsunit/regress/regress-embedded-cons-string
2 (00:02.715) mjsunit/regress/regress-embedded-cons-string
3 (00:00.812) mjsunit/regress/regress-embedded-cons-string
Running tests for ia32.debug
No connection to distribution server; running tests locally.
[00:03|% 100|+ 3|- 0]: Done
--- Total time: 00:03.840 ---
1 (00:03.816) mjsunit/regress/regress-embedded-cons-string
2 (00:03.216) mjsunit/regress/regress-embedded-cons-string
3 (00:01.412) mjsunit/regress/regress-embedded-cons-string
-------------------------------------------------------------------------------------------
Without this CL, the running times are cut by half, but even 4 seconds are
*far*
too long. Unit tests should really run far below 1 second.
https://codereview.chromium.org/24495005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
