Thanks Michael!
https://codereview.chromium.org/27023003/diff/3001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/27023003/diff/3001/src/heap.h#newcode2374
src/heap.h:2374: intptr_t full_codegen_bytes_;
On 2013/10/14 09:18:37, Michael Starzinger wrote:
nit: I know the existing code is not consistent about that at all, but
I think
these should be size_t here.
Done.
https://codereview.chromium.org/27023003/diff/9001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/27023003/diff/9001/src/heap.h#newcode2366
src/heap.h:2366: size_t full_codegen_bytes_generated_;
On 2013/10/14 13:12:57, Michael Starzinger wrote:
Let's add a short one-liner comment here saying that these counters
are
monotonically increasing and never reset.
Done.
https://codereview.chromium.org/27023003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
