LGTM with one nit. Will land this once nit is addressed.
https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc#newcode14564
src/runtime.cc:14564: CONVERT_ARG_CHECKED(JSReceiver, obj, 0);
Using CONVERT_ARG_HANDLE_CHECKED here will give an implicit handle
within the passed arguments (the GC knows about the position of the
"args" object on the stack). This is the cheapest way to get a handle
and avoids the "js_object" handle below.
https://codereview.chromium.org/27070002/diff/5001/src/runtime.cc#newcode14578
src/runtime.cc:14578: JSObject::SetObserved(js_object);
You can use Handle<JSObject>::cast() here to do the casting.
https://codereview.chromium.org/27070002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
