LGTM with nits.
https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-arm.cc#newcode3862
src/arm/macro-assembler-arm.cc:3862: Label *no_memento_found) {
nit: "Label* no_memento_found" (swap * and the space)
https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):
https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-arm.h#newcode1391
src/arm/macro-assembler-arm.h:1391: // If allocation info is present,
condition flags are set to equal
nit: s/equal/eq./
Since the enum value is called "eq" on ARM, let's keep exactly that term
in the comment (but with a trailing full stop).
https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x64.cc#newcode4925
src/x64/macro-assembler-x64.cc:4925: Label *no_memento_found) {
nit: s/ */* /
https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):
https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x64.h#newcode1415
src/x64/macro-assembler-x64.h:1415: // If allocation info is present,
condition flags are set to equal
nit: trailing full stop
https://codereview.chromium.org/26841009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
