On 2013/10/16 08:21:07, Michael Starzinger wrote:
LGTM (just one suggestive nit).
https://codereview.chromium.org/27335002/diff/3001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/27335002/diff/3001/src/objects.cc#newcode345
src/objects.cc:345: Handle<Object>
JSObject::GetPropertyWithForeignCallback(
nit: Does this need to be a member method on JSObject at all? Maybe it
makes
sense to make it just a static helper. Simplifies the API exposed through
the
header.
After what we talked about offline, there is no need to check for scheduled
exceptions after foreign callback. So I'm removing the function by inlining
it.
https://codereview.chromium.org/27335002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
