Reviewers: Sven Panne,
Message:
Hey Sven,
Next baby step towards Hydrogen StringAddStub. PTAL
-- Benedikt
Description:
Add support for Token::NE and Token::NE_STRICT to TokenToCondition.
This is required to be able to use these tokens with
HCompareNumericAndBranch.
Please review this at https://codereview.chromium.org/27043010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -0 lines):
M src/arm/lithium-codegen-arm.cc
M src/ia32/lithium-codegen-ia32.cc
M src/x64/lithium-codegen-x64.cc
Index: src/arm/lithium-codegen-arm.cc
diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc
index
6979442ab5dd8ac3c41f5973f3166ba1175831f8..d2fd70f0aa8f4f931ef30015e839299228d7b6e0
100644
--- a/src/arm/lithium-codegen-arm.cc
+++ b/src/arm/lithium-codegen-arm.cc
@@ -2336,6 +2336,10 @@ Condition LCodeGen::TokenToCondition(Token::Value
op, bool is_unsigned) {
case Token::EQ_STRICT:
cond = eq;
break;
+ case Token::NE:
+ case Token::NE_STRICT:
+ cond = ne;
+ break;
case Token::LT:
cond = is_unsigned ? lo : lt;
break;
Index: src/ia32/lithium-codegen-ia32.cc
diff --git a/src/ia32/lithium-codegen-ia32.cc
b/src/ia32/lithium-codegen-ia32.cc
index
a9e1f5ae8ceb1a1a733a9bd15217908abe20c307..8adc25c6394de7e84b4025fc570b49b750cd3485
100644
--- a/src/ia32/lithium-codegen-ia32.cc
+++ b/src/ia32/lithium-codegen-ia32.cc
@@ -2503,6 +2503,10 @@ Condition LCodeGen::TokenToCondition(Token::Value
op, bool is_unsigned) {
case Token::EQ_STRICT:
cond = equal;
break;
+ case Token::NE:
+ case Token::NE_STRICT:
+ cond = not_equal;
+ break;
case Token::LT:
cond = is_unsigned ? below : less;
break;
Index: src/x64/lithium-codegen-x64.cc
diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc
index
b95ac3a25232974e96b03763a452e75356d1c54b..6fe64c553ec39222eb7741696892cc436b5d5799
100644
--- a/src/x64/lithium-codegen-x64.cc
+++ b/src/x64/lithium-codegen-x64.cc
@@ -2048,6 +2048,10 @@ inline Condition
LCodeGen::TokenToCondition(Token::Value op, bool is_unsigned) {
case Token::EQ_STRICT:
cond = equal;
break;
+ case Token::NE:
+ case Token::NE_STRICT:
+ cond = not_equal;
+ break;
case Token::LT:
cond = is_unsigned ? below : less;
break;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
