Revision: 17243
Author: [email protected]
Date: Wed Oct 16 14:39:27 2013 UTC
Log: Fix lower bound of shr.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/27503002
http://code.google.com/p/v8/source/detail?r=17243
Modified:
/branches/bleeding_edge/src/typing.cc
=======================================
--- /branches/bleeding_edge/src/typing.cc Mon Oct 14 12:14:42 2013 UTC
+++ /branches/bleeding_edge/src/typing.cc Wed Oct 16 14:39:27 2013 UTC
@@ -603,8 +603,10 @@
case Token::SHR:
RECURSE(Visit(expr->left()));
RECURSE(Visit(expr->right()));
- // TODO(rossberg): we could use an UnsignedSmi as lower bound here...
- NarrowType(expr, Bounds(Type::Unsigned32(), isolate_));
+ // TODO(rossberg): The upper bound would be Unsigned32, but since
there
+ // is no 'positive Smi' type for the lower bound, we use the smallest
+ // union of Smi and Unsigned32 as upper bound instead.
+ NarrowType(expr, Bounds(Type::Smi(), Type::Number(), isolate_));
break;
case Token::ADD: {
RECURSE(Visit(expr->left()));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
