Reviewers: mvstanton,
Description:
Fix leak in optimizing compiler thread.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/27473006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+12, -9 lines):
M src/optimizing-compiler-thread.h
M src/optimizing-compiler-thread.cc
Index: src/optimizing-compiler-thread.cc
diff --git a/src/optimizing-compiler-thread.cc
b/src/optimizing-compiler-thread.cc
index
fa2da9761a03bdcff6596909dac20ee0f05ebcc3..0b35648dac477ea16978dfb01e08ab6851f6368b
100644
--- a/src/optimizing-compiler-thread.cc
+++ b/src/optimizing-compiler-thread.cc
@@ -37,6 +37,17 @@
namespace v8 {
namespace internal {
+OptimizingCompilerThread::~OptimizingCompilerThread() {
+#ifdef DEBUG
+ for (int i = 0; i < osr_buffer_capacity_; i++) {
+ CHECK_EQ(NULL, osr_buffer_[i]);
+ }
+#endif
+ DeleteArray(osr_buffer_);
+ ASSERT_EQ(0, input_queue_length_);
+ DeleteArray(input_queue_);
+}
+
void OptimizingCompilerThread::Run() {
#ifdef DEBUG
Index: src/optimizing-compiler-thread.h
diff --git a/src/optimizing-compiler-thread.h
b/src/optimizing-compiler-thread.h
index
a9e108c5cb18ee3df8e5e8c71622c4cefa85d1a5..8e36f5c195a6213fc1df0c7ec417b7d2a54b5d47
100644
--- a/src/optimizing-compiler-thread.h
+++ b/src/optimizing-compiler-thread.h
@@ -68,15 +68,7 @@ class OptimizingCompilerThread : public Thread {
for (int i = 0; i < osr_buffer_capacity_; i++) osr_buffer_[i] = NULL;
}
- ~OptimizingCompilerThread() {
- ASSERT_EQ(0, input_queue_length_);
-#ifdef DEBUG
- for (int i = 0; i < osr_buffer_capacity_; i++) {
- CHECK_EQ(NULL, osr_buffer_[i]);
- }
-#endif
- DeleteArray(osr_buffer_);
- }
+ ~OptimizingCompilerThread();
void Run();
void Stop();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
