Looks good, except for the code duplication. Can we perhaps merge both
functions
into one that takes a type (i.e., a lower bound) as an additional argument
and
special-cases internally based on that?
https://codereview.chromium.org/27674002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/27674002/diff/1/src/hydrogen.cc#newcode1287
src/hydrogen.cc:1287: // Everything in here is safe wrt. observable side
effects.
Nit: this comment seems redundant, the next line says it all.
https://codereview.chromium.org/27674002/diff/1/src/hydrogen.cc#newcode1294
src/hydrogen.cc:1294: // Make the hash maks from the length of the
number string cache. It
Typo: mask
https://codereview.chromium.org/27674002/diff/1/src/hydrogen.cc#newcode1340
src/hydrogen.cc:1340: // Everything in here is safe wrt. observable side
effects.
Nit: as above
https://codereview.chromium.org/27674002/diff/1/src/hydrogen.cc#newcode1351
src/hydrogen.cc:1351: // Make the hash maks from the length of the
number string cache. It
Same typo
https://codereview.chromium.org/27674002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
