LGTM with nits.
https://codereview.chromium.org/27197013/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/27197013/diff/1/src/x64/lithium-codegen-x64.cc#newcode3686
src/x64/lithium-codegen-x64.cc:3686: Operand nan_operand = __
ExternalOperand(nan);
nit: please use "masm->" instead of "__" here. "__" is for emitting
instructions. I think I'd also inline nan_operand directly:
__ movsd(input_reg, masm->ExternalOperand(nan));
https://codereview.chromium.org/27197013/diff/1/src/x64/lithium-codegen-x64.cc#newcode3692
src/x64/lithium-codegen-x64.cc:3692: Operand ninf_operand = __
ExternalOperand(ninf);
same here
https://codereview.chromium.org/27197013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
