LGTM with nits.
https://codereview.chromium.org/27704002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/27704002/diff/1/tools/run-tests.py#newcode335
tools/run-tests.py:335: s.tests = [ t.CopyAddingFlags(v) for t in
s.tests for v in s.VariantFlags(t, VARIANT_FLAGS) ]
nit: 80 cols please. I'd format as:
s.tests = [ t.CopyAddingFlags(v)
for t in s.tests
for v in s.VariantFlags(t, VARIANT_FLAGS) ]
https://codereview.chromium.org/27704002/diff/1/tools/testrunner/local/statusfile.py
File tools/testrunner/local/statusfile.py (right):
https://codereview.chromium.org/27704002/diff/1/tools/testrunner/local/statusfile.py#newcode38
tools/testrunner/local/statusfile.py:38: ONLY_STANDARD_VARIANT =
"ONLY_STANDARD_VARIANT"
Suggestion for a shorter name: NO_VARIANTS. But I leave the decision up
to you.
https://codereview.chromium.org/27704002/diff/1/tools/testrunner/local/statusfile.py#newcode47
tools/testrunner/local/statusfile.py:47: PASS_OR_FAIL, ALWAYS,
ONLY_STANDARD_VARIANT]:
nit: please match the order of the definitions above (i.e. move the new
guy between FLAKY and FAIL_OK)
https://codereview.chromium.org/27704002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
