LGTM, only a few nits. I only reviewed the Crankshaft changes, didn't look
at
the Sodium tool.
https://codereview.chromium.org/24957003/diff/32001/src/codegen.cc
File src/codegen.cc (right):
https://codereview.chromium.org/24957003/diff/32001/src/codegen.cc#newcode138
src/codegen.cc:138: code->kind() == Code::FUNCTION;
nit: Indentation is off.
https://codereview.chromium.org/24957003/diff/32001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/24957003/diff/32001/src/flag-definitions.h#newcode827
src/flag-definitions.h:827: DEFINE_bool(opt_code_positions, false,
"annotate optimize code with source code positions")
nit: s/opt_code_positions/print_opt_code_positions/
https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions.cc#newcode748
src/hydrogen-instructions.cc:748: ASSERT(next->position() ==
RelocInfo::kNoPosition);
nit: This if cascade looks awfully complex, especially because this
ASSERT will always hold. Can we merge that into just one if-statement?
https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions.cc#newcode789
src/hydrogen-instructions.cc:789: ASSERT(previous->position() ==
RelocInfo::kNoPosition);
nit: Likewise.
https://codereview.chromium.org/24957003/diff/32001/src/hydrogen-instructions.cc#newcode789
src/hydrogen-instructions.cc:789: ASSERT(previous->position() ==
RelocInfo::kNoPosition);
nit: Likewise.
https://codereview.chromium.org/24957003/diff/32001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/24957003/diff/32001/src/hydrogen.h#newcode195
src/hydrogen.h:195: // Add the inlined function exit sequence, adding an
HLeaveInlined
nit: Can we add an empty new-line before the comment, makes it easier to
read.
https://codereview.chromium.org/24957003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
