LGTM with a request for test.
https://codereview.chromium.org/28723002/diff/40001/test/mjsunit/harmony/math-sign.js
File test/mjsunit/harmony/math-sign.js (right):
https://codereview.chromium.org/28723002/diff/40001/test/mjsunit/harmony/math-sign.js#newcode30
test/mjsunit/harmony/math-sign.js:30: assertEquals("Infinity",
String(1/Math.sign(0)));
Needs tests for +0 and -0:
var x = 1e-200
var y = -1e-200
var z = x*y // -0, confirm by 1/z == -Infinity
Math.sign(z);
https://codereview.chromium.org/28723002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
