NOT LGTM. The API is wrong, and the whole concept is a bit strange: I don't
really believe that probing the physical memory in any way is the right way
to
go, but even if I did: This is something *global*, not isolate-local.
Even if we want to keep this physical memory concept, the API has to change
to
make it clear that this is a global setting. An ugly hack would be
pretending
that it is isolate-local, but then we should pass the isolate and mark it
clearly as a hack.
https://codereview.chromium.org/29053002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/29053002/diff/1/src/api.cc#newcode6440
src/api.cc:6440: i::Isolate* isolate = i::Isolate::Current();
o_O This is fundamentally wrong, and I can't see how we can ever remove
Current() here. Note that this is on death row already, and I will
object any CL which introduces further calls of it.
https://codereview.chromium.org/29053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
