https://codereview.chromium.org/28783002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/28783002/diff/1/src/objects.cc#newcode16322
src/objects.cc:16322: Type* new_type = UpdateType(cell, value);
On 2013/10/21 12:16:35, rossberg wrote:
Nit: could inline this
Nope. This cannot be inlined, as "cell" is a handle and UpdateType() can
cause a GC, this would be unsafe and GCMole would complain. This would
be clearer if UpdateType() would return a handle instead of a raw
pointer. :)
https://codereview.chromium.org/28783002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/28783002/diff/1/src/objects.h#newcode9199
src/objects.h:9199: static Type* UpdateType(Handle<PropertyCell> cell,
On 2013/10/21 12:16:35, rossberg wrote:
Maybe it would be clearer to call this UpdatedType
Done.
https://codereview.chromium.org/28783002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
