LGTM with nits -- pretty much rubberstamped.
As discussed offline, I'm fine with landing this, but before investing more
time
into bash testing, we should seriously consider porting the script to
Python.
https://codereview.chromium.org/32283002/diff/1/tools/test-push-to-trunk.sh
File tools/test-push-to-trunk.sh (right):
https://codereview.chromium.org/32283002/diff/1/tools/test-push-to-trunk.sh#newcode2
tools/test-push-to-trunk.sh:2: # Copyright 2012 the V8 project authors.
All rights reserved.
nit: 2013
https://codereview.chromium.org/32283002/diff/1/tools/test-push-to-trunk.sh#newcode36
tools/test-push-to-trunk.sh:36: # TODO(machenbach): Represent test
exectations/mock output without an array
nit: expectations
https://codereview.chromium.org/32283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
