here's a few comments, more comming...
https://codereview.chromium.org/32643004/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/32643004/diff/1/src/ic.cc#newcode1371
src/ic.cc:1371: return LoadIC::Load(object, Handle<String>::cast(key));
Don't you need to install the generic stub here, too? With a
corresponding trace?
https://codereview.chromium.org/32643004/diff/1/src/ic.cc#newcode1381
src/ic.cc:1381: if (state() == UNINITIALIZED) stub = string_stub();
need else here to TRACE_GENERIC
https://codereview.chromium.org/32643004/diff/1/src/ic.cc#newcode1392
src/ic.cc:1392: }
need else here to TRACE_GENERIC
https://codereview.chromium.org/32643004/diff/1/src/ic.cc#newcode1395
src/ic.cc:1395: TRACE_GENERIC_IC(isolate(), "KeyedLoadIC", "force
generic");
Comment is wrong. Should not be "force generic", but rather "access
check needed"
https://codereview.chromium.org/32643004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
