First round of comments.
https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.cc#newcode690
src/code-stubs-hydrogen.cc:690: HInstruction* argument =
Add<HAccessArgumentsAt>(elements, constant_one,
Fix indentation to have all arguments on next line.
https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.cc#newcode739
src/code-stubs-hydrogen.cc:739: HInstruction* argument =
Add<HAccessArgumentsAt>(argument_elements,
Funky indentation, put all arguments on next line.
https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.cc#newcode1169
src/code-stubs-hydrogen.cc:1169: HValue* keyed_minus =
AddUncasted<HSub>(key,
Funky indentation again.
https://codereview.chromium.org/34523004/diff/20001/src/code-stubs-hydrogen.cc#newcode1179
src/code-stubs-hydrogen.cc:1179: HValue* keyed_plus =
AddUncasted<HAdd>(keyed_minus,
Funky indentation again.
https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode5502
src/hydrogen.cc:5502: HInstruction*
HGraphBuilder::AddLoadNamedField(HValue* object,
Can we get rid of this AddLoadNamedField and BuildLoadNamedField
functions, and put the logic from BuildLoadNamedField into a specialized
NewUncasted<LoadNamedField> template?
https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode6826
src/hydrogen.cc:6826: HInstruction* sqrt =
AddUncasted<HUnaryMathOperation>(left,
Funky indentation. Please put arguments on next line.
https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode7104
src/hydrogen.cc:7104: call =
PreProcessCall(New<HCallKnownGlobal>(expr->target(),
Indentation, please put arguments on next line.
https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.cc#newcode8838
src/hydrogen.cc:8838: HAccessArgumentsAt* result =
New<HAccessArgumentsAt>(elements, length,
Indentation, please put arguments on next line.
https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h#newcode1956
src/hydrogen.h:1956: // "use" bind to make the compiler happy.
We have a USE macro for this.
https://codereview.chromium.org/34523004/diff/20001/src/hydrogen.h#newcode1972
src/hydrogen.h:1972: // "use" lookup to make the compiler happy.
Same as above.
https://codereview.chromium.org/34523004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
