LGTM with a nit.
https://codereview.chromium.org/34023002/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/34023002/diff/40001/src/objects.cc#newcode6942
src/objects.cc:6942: Map::AddTransition(map,
handle(isolate->heap()->observed_symbol()),
nit: Better use isolate->factory()->observed_symbol(), this uses the
slot in the roots array as an implicit handle without allocating a new
handle and is also easier to read.
https://codereview.chromium.org/34023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
