Reviewers: Michael Starzinger,
Description:
force accessor pair loads backed by simple api calls to be generic loads
when
crankshafted
[email protected]
BUG=
Please review this at https://chromiumcodereview.appspot.com/34773003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -1 lines):
src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
73b23cb2fd4c6395a5c1fb21857b6d550af09ae8..d5c57ee540e2bf54343a49894411ec60bd65348a
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -4755,7 +4755,10 @@ bool
HOptimizedGraphBuilder::PropertyAccessInfo::LoadResult(Handle<Map> map) {
if (!callback->IsAccessorPair()) return false;
Object* getter = Handle<AccessorPair>::cast(callback)->getter();
if (!getter->IsJSFunction()) return false;
- accessor_ = handle(JSFunction::cast(getter));
+ Handle<JSFunction> accessor = handle(JSFunction::cast(getter));
+ CallOptimization call_optimization(accessor);
+ if (call_optimization.is_simple_api_call()) return false;
+ accessor_ = accessor;
} else if (lookup_.IsConstant()) {
constant_ = handle(lookup_.GetConstantFromMap(*map), isolate());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
