Reviewers: Toon Verwaest, danno, Jakob, Paul Lind,
Message:
PTAL, this and 2 related CLs provide complete alignment of FixedDoubleArrays
which then allows a big MIPS performance improvement via
https://codereview.chromium.org/35463002.
Description:
Enable double alignment for constructed arrays.
2nd (of 3) CL's to ensure complete alignment of FixedDoubleArrays.
TEST=
BUG=
Please review this at https://codereview.chromium.org/35133002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -1 lines):
M src/hydrogen.cc
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
9d990bf93cc857ba325f11163fac940f84cc5c46..ddf82a11ee11207e0706f5b479deb20a2d2f0c55
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -2122,9 +2122,11 @@ HValue*
HGraphBuilder::JSArrayBuilder::AllocateArray(HValue* size_in_bytes,
Representation::Smi());
length_field = builder()->Add<HForceRepresentation>(length_field,
Representation::Smi());
+ InstanceType instance_type = IsFastDoubleElementsKind(kind_)
+ ? FIXED_DOUBLE_ARRAY_TYPE : JS_ARRAY_TYPE;
// Allocate (dealing with failure appropriately)
HAllocate* new_object = builder()->Add<HAllocate>(size_in_bytes,
- HType::JSArray(), NOT_TENURED, JS_ARRAY_TYPE);
+ HType::JSArray(), NOT_TENURED, instance_type);
// Fill in the fields: map, properties, length
HValue* map;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
