https://codereview.chromium.org/32483006/diff/50001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/32483006/diff/50001/src/objects.cc#newcode4451
src/objects.cc:4451: Map* fast = obj->map();
On 2013/10/22 16:29:50, Michael Starzinger wrote:
On 2013/10/22 02:30:54, rafaelw wrote:
> I'm assuming the cache-hit path is using raw pointers for perf
reasons (which
> seems scary). Let me know if this is wrong, and I'll handlify.
Yes, you are right, this is tricky. I think it gets easier if we not
pull out
obj->map() into a local variable. Also, since we handlify "result"
even in the
fast case already, I think it should be fine to pull up the
handlification of
"result" to line 4452 here.
Done.
https://codereview.chromium.org/32483006/diff/50001/src/objects.cc#newcode4466
src/objects.cc:4466: Handle<Map> fresh = Map::CopyNormalized(fast,
SHARED_NORMALIZED_MAP);
DOH! Done.
On 2013/10/22 16:29:50, Michael Starzinger wrote:
This shouldn't compile in debug mode, as "fast" is not a handle and
the "mode"
argument is missing here.
https://codereview.chromium.org/32483006/diff/50001/src/objects.cc#newcode4479
src/objects.cc:4479: return handle(Map::cast(result));
Right. Got it.
On 2013/10/22 16:29:50, Michael Starzinger wrote:
At this point "result" might be stale.
https://codereview.chromium.org/32483006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
