https://codereview.chromium.org/34503003/diff/40001/src/runtime.cc
File src/runtime.cc (left):
https://codereview.chromium.org/34503003/diff/40001/src/runtime.cc#oldcode2940
src/runtime.cc:2940: target_shared->ReplaceCode(source_shared->code());
On 2013/10/23 08:05:20, Michael Starzinger wrote:
On 2013/10/22 19:25:03, Dmitry Lomov (chromium) wrote:
> On 2013/10/22 17:01:28, Michael Starzinger wrote:
> > I have the feeling that removing the call to
SharedFunctionInfo::ReplaceCode
> > here will break ProxyFix() as the shared function info backing the
newly
fixed
> > JSFunction created from that proxy will still point to the
Builtins::kIllegal
> > IIUC.
> See below line 2951 where the call to ReplaceCode is repeated.
Nope, SharedFunctionInfo::ReplaceCode and JSFunction::RecplaceCode are
actually
two different functions.
Rats, you are right.
https://codereview.chromium.org/34503003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
