lgtm
https://codereview.chromium.org/26410004/diff/10001/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):
https://codereview.chromium.org/26410004/diff/10001/src/x64/assembler-x64.cc#newcode1468
src/x64/assembler-x64.cc:1468: ASSERT(RelocInfo::IsNone(rmode));
On 2013/10/17 06:11:48, haitao.feng wrote:
I will submit a CL to move the movq(Register dst, int64_t value, ,
RelocInfo::Mode rmode) into X64 macro assembler and drop the
relocation info
mode parameter.
For the movq(Register dst, void* value, RelocInfo::Mode rmode), the
rmode could
be EXTERNAL_REFERENCE or NONE64, it is NONE64 for SMIs or Failures as
they will
not be relocated. I will check each NONE64 occurrence to make sure
they use the
right function.
Done.
https://codereview.chromium.org/26410004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
