Some comments inlined. I could continue refactoring in this CL if you
prefer.
https://codereview.chromium.org/39543003/diff/1/src/x64/assembler-x64.cc
File src/x64/assembler-x64.cc (right):
https://codereview.chromium.org/39543003/diff/1/src/x64/assembler-x64.cc#newcode1533
src/x64/assembler-x64.cc:1533: movq(dst, Smi::cast(*value),
RelocInfo::NONE64);
In the macro assembler, we have Move(Register, Smi*), I will try to use
that when move this instruction into macro assembler.
https://codereview.chromium.org/39543003/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/39543003/diff/1/src/x64/lithium-codegen-x64.cc#newcode160
src/x64/lithium-codegen-x64.cc:160: __ movq(kScratchRegister,
reinterpret_cast<Address>(kSlotsZapValue),
It might make sense to define kSlotsZapValue as Address in v8globals.h,
but that requires to change ARM and MIPS assembler a little.
https://codereview.chromium.org/39543003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
