Reviewers: Benedikt Meurer,
Description:
Revert "Make Array.prototype.pop throw if the last element is not
configurable."
This reverts commit r17346.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/39593002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -35 lines):
M src/array.js
D test/mjsunit/regress/regress-array-pop-nonconfigurable.js
M tools/presubmit.py
Index: test/mjsunit/regress/regress-array-pop-nonconfigurable.js
diff --git a/test/mjsunit/regress/regress-array-pop-nonconfigurable.js
b/test/mjsunit/regress/regress-array-pop-nonconfigurable.js
deleted file mode 100644
index
129e1980a446bee71e99a04076f46d1cd4d00b5c..0000000000000000000000000000000000000000
--- a/test/mjsunit/regress/regress-array-pop-nonconfigurable.js
+++ /dev/null
@@ -1,31 +0,0 @@
-// Copyright 2013 the V8 project authors. All rights reserved.
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-// * Redistributions of source code must retain the above copyright
-// notice, this list of conditions and the following disclaimer.
-// * Redistributions in binary form must reproduce the above
-// copyright notice, this list of conditions and the following
-// disclaimer in the documentation and/or other materials provided
-// with the distribution.
-// * Neither the name of Google Inc. nor the names of its
-// contributors may be used to endorse or promote products derived
-// from this software without specific prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-var a = [];
-Object.defineProperty(a, 0, {});
-assertThrows(function() { a.pop(); });
-
Index: src/array.js
diff --git a/src/array.js b/src/array.js
index
e98d7f5b53aba315558d9297950d093c7f308195..2649798ac1c0b7edb94cecb0335e8e677e62c258
100644
--- a/src/array.js
+++ b/src/array.js
@@ -430,7 +430,7 @@ function ArrayPop() {
n--;
var value = this[n];
- Delete(this, ToName(n), true);
+ delete this[n];
this.length = n;
return value;
}
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index
1ab63477745846c7f8926efa0106b06caadd1fd5..780dab9cf9e4c86e347dac5b382ab989268e6dc6
100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -282,8 +282,8 @@ class SourceProcessor(SourceFileProcessor):
Check that all files include a copyright notice and no trailing
whitespaces.
"""
- RELEVANT_EXTENSIONS = ['.js', '.cc', '.h', '.py', '.c',
- '.status', '.gyp', '.gypi']
+ RELEVANT_EXTENSIONS = ['.js', '.cc', '.h', '.py', '.c', 'SConscript',
+ 'SConstruct', '.status', '.gyp', '.gypi']
# Overwriting the one in the parent class.
def FindFilesIn(self, path):
@@ -292,7 +292,7 @@ class SourceProcessor(SourceFileProcessor):
stdout=PIPE, cwd=path, shell=True)
result = []
for file in output.stdout.read().split():
- for dir_part in
os.path.dirname(file).replace(os.sep, '/').split('/'):
+ for dir_part in os.path.dirname(file).split(os.sep):
if self.IgnoreDir(dir_part):
break
else:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
