Drive-by nits.
High-level: I liked having a mode where we have compiler optimizations but
slow
asserts. So I think OPTIMIZED_DEBUG should be #defined in
v8_optimized_debug=2
mode instead of NDEBUG, rather than in the =1 mode. (Remember to update the
CL
description accordingly if you change this.)
Other than that LGTM :-)
https://codereview.chromium.org/39183004/diff/110001/src/checks.h
File src/checks.h (right):
https://codereview.chromium.org/39183004/diff/110001/src/checks.h#newcode283
src/checks.h:283: #if ENABLE_SLOW_ASSERTS
s/if/ifdef/?
https://codereview.chromium.org/39183004/diff/110001/src/incremental-marking.cc
File src/incremental-marking.cc (right):
https://codereview.chromium.org/39183004/diff/110001/src/incremental-marking.cc#newcode731
src/incremental-marking.cc:731: #if ENABLE_SLOW_ASSERTS
s/if/ifdef/
https://codereview.chromium.org/39183004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
