LGTM with one comment to address.
https://codereview.chromium.org/40113002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/40113002/diff/1/test/cctest/test-parsing.cc#newcode1093
test/cctest/test-parsing.cc:1093: void SetParserFlags(T* parser,
i::EnumSet<ParserFlag> flags) {
Just use ParserBase instead of a template parameter here. With my recent
changes there is a common base class for these accessors.
https://codereview.chromium.org/40113002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
