Ping.

On Wed, Oct 23, 2013 at 7:48 AM, <[email protected]> wrote:

> LGTM
>
>
> https://codereview.chromium.**org/36313002/diff/50001/src/**
> object-observe.js<https://codereview.chromium.org/36313002/diff/50001/src/object-observe.js>
> File src/object-observe.js (right):
>
> https://codereview.chromium.**org/36313002/diff/50001/src/**
> object-observe.js#newcode398<https://codereview.chromium.org/36313002/diff/50001/src/object-observe.js#newcode398>
> src/object-observe.js:398: for (var prop in changeRecord) {
> Do we want inherited properties?
>
> Do we want non enumerable properties?
>
> I think we do want inherited but not enumerable properties so this is
> correct but we haven't written the spec for this yet.
>
> https://codereview.chromium.**org/36313002/<https://codereview.chromium.org/36313002/>
>

-- 
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to