LGTM. I like. Just one more nit.
https://codereview.chromium.org/39183004/diff/180001/src/checks.h
File src/checks.h (right):
https://codereview.chromium.org/39183004/diff/180001/src/checks.h#newcode306
src/checks.h:306: #define SLOW_ASSERT(condition) ((void) 0)
nit: Let's move the definition of SLOW assert out of this block up to
line 284 and 286 respectively. Makes it easier to read and the
conditions less cascaded.
https://codereview.chromium.org/39183004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
