Reviewers: machenbach,
Description:
Reland "Make Array.prototype.pop throw if the last element is not
configurable."
This relands r17346.
[email protected]
BUG=311164
Please review this at https://codereview.chromium.org/43923002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -9 lines):
M src/array.js
A + test/mjsunit/regress/regress-array-pop-nonconfigurable.js
M tools/presubmit.py
Index: src/array.js
diff --git a/src/array.js b/src/array.js
index
2649798ac1c0b7edb94cecb0335e8e677e62c258..e98d7f5b53aba315558d9297950d093c7f308195
100644
--- a/src/array.js
+++ b/src/array.js
@@ -430,7 +430,7 @@ function ArrayPop() {
n--;
var value = this[n];
- delete this[n];
+ Delete(this, ToName(n), true);
this.length = n;
return value;
}
Index: test/mjsunit/regress/regress-array-pop-nonconfigurable.js
diff --git a/test/mjsunit/regress/regress-173361.js
b/test/mjsunit/regress/regress-array-pop-nonconfigurable.js
similarity index 95%
copy from test/mjsunit/regress/regress-173361.js
copy to test/mjsunit/regress/regress-array-pop-nonconfigurable.js
index
f9cfb6684c0d52996c7ceac8412defbaf48a5eeb..129e1980a446bee71e99a04076f46d1cd4d00b5c
100644
--- a/test/mjsunit/regress/regress-173361.js
+++ b/test/mjsunit/regress/regress-array-pop-nonconfigurable.js
@@ -25,9 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-// Flags: --harmony
+var a = [];
+Object.defineProperty(a, 0, {});
+assertThrows(function() { a.pop(); });
-const x = 7;
-
-function f() { const y = 8; }
-f();
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index
780dab9cf9e4c86e347dac5b382ab989268e6dc6..1ab63477745846c7f8926efa0106b06caadd1fd5
100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -282,8 +282,8 @@ class SourceProcessor(SourceFileProcessor):
Check that all files include a copyright notice and no trailing
whitespaces.
"""
- RELEVANT_EXTENSIONS = ['.js', '.cc', '.h', '.py', '.c', 'SConscript',
- 'SConstruct', '.status', '.gyp', '.gypi']
+ RELEVANT_EXTENSIONS = ['.js', '.cc', '.h', '.py', '.c',
+ '.status', '.gyp', '.gypi']
# Overwriting the one in the parent class.
def FindFilesIn(self, path):
@@ -292,7 +292,7 @@ class SourceProcessor(SourceFileProcessor):
stdout=PIPE, cwd=path, shell=True)
result = []
for file in output.stdout.read().split():
- for dir_part in os.path.dirname(file).split(os.sep):
+ for dir_part in
os.path.dirname(file).replace(os.sep, '/').split('/'):
if self.IgnoreDir(dir_part):
break
else:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
