Implemented all feedback.
https://codereview.chromium.org/40133004/diff/1/src/i18n.js
File src/i18n.js (right):
https://codereview.chromium.org/40133004/diff/1/src/i18n.js#newcode2002
src/i18n.js:2002: * Adds a new method.
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
Remove * Adds a new method comment. That belongs to CL description.
Done.
https://codereview.chromium.org/40133004/diff/1/src/i18n.js#newcode2016
src/i18n.js:2016: var normForm = NORMALIZATION_FORMS.indexOf(form);
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
normalizationForm, don't abbreviate (except for loop indices).
Done.
https://codereview.chromium.org/40133004/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14069
src/runtime.cc:14069: static const UNormalizationMode normForms[] =
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
normalizationForms[]
Done.
https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14080
src/runtime.cc:14080: // TODO(mnita) check Normalizer2 (not available in
ICU 46)
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
// TODO(mnita): switch to Normalizer2 when we switch to ICU 51 or
above.
Done.
https://codereview.chromium.org/40133004/diff/1/src/runtime.cc#newcode14084
src/runtime.cc:14084: if (U_FAILURE(status)) return
isolate->heap()->undefined_value();
On 2013/10/24 19:54:18, Nebojša Ćirić wrote:
if () {
statement;
}
not
if () statement;
Done.
https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalization.js
File test/intl/string/normalization.js (right):
https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalization.js#newcode32
test/intl/string/normalization.js:32: // These are examples of data one
might encounter in real use
On 2013/10/24 21:36:14, Nebojša Ćirić wrote:
End full sentences with .
Done.
https://codereview.chromium.org/40133004/diff/1/test/intl/string/normalization.js#newcode66
test/intl/string/normalization.js:66: // Make sure we throw RangeError,
as the standard requires
On 2013/10/24 21:36:14, Nebojša Ćirić wrote:
.
Done.
https://codereview.chromium.org/40133004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
