https://codereview.chromium.org/32523008/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode346
src/objects.cc:346: Handle<Object>
JSObject::EnsureWritableFastElements(Handle<JSObject> object) {
On 2013/10/25 08:11:44, Michael Starzinger wrote:
IIUC the return type of this function can be narrowed down to either
Handle<FixedArray> or Handle<FixedArrayBase>.
Done.
https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14403
src/objects.cc:14403: Handle<SeededNumberDictionary> dict =
handle(object->element_dictionary());
On 2013/10/25 08:11:44, Michael Starzinger wrote:
nit: Let's use the constructor syntax here instead of an assignment to
be
consistent with the rest of the code ...
Handle<SeededNumberDictionary> dict(object->element_dictionary());
Done.
https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14413
src/objects.cc:14413: PretenureFlag tenure =
object->GetHeap()->InNewSpace(*object) ?
On 2013/10/25 08:11:44, Michael Starzinger wrote:
nit: Using isolate->heap() here is cheaper and cleaner.
Done.
https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14444
src/objects.cc:14444: if (elements_base->map() ==
object->GetHeap()->fixed_double_array_map()) {
On 2013/10/25 08:11:44, Michael Starzinger wrote:
nit: Using isolate->heap() here is cheaper and cleaner.
Done.
https://codereview.chromium.org/32523008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
