Revision: 17422
Author: [email protected]
Date: Tue Oct 29 07:56:47 2013 UTC
Log: Function ElementsAreSafeToExamine was undefined in release heap
verify.
[email protected]
Review URL: https://codereview.chromium.org/48963006
http://code.google.com/p/v8/source/detail?r=17422
Modified:
/branches/bleeding_edge/src/objects-debug.cc
/branches/bleeding_edge/src/objects.h
=======================================
--- /branches/bleeding_edge/src/objects-debug.cc Fri Oct 25 12:26:47 2013
UTC
+++ /branches/bleeding_edge/src/objects-debug.cc Tue Oct 29 07:56:47 2013
UTC
@@ -304,6 +304,13 @@
void ExternalDoubleArray::ExternalDoubleArrayVerify() {
CHECK(IsExternalDoubleArray());
}
+
+
+bool JSObject::ElementsAreSafeToExamine() {
+ return (FLAG_use_gvn && FLAG_use_allocation_folding) ||
+ reinterpret_cast<Map*>(elements()) !=
+ GetHeap()->one_pointer_filler_map();
+}
void JSObject::JSObjectVerify() {
@@ -1137,13 +1144,6 @@
PrintF("\n");
}
-
-
-bool JSObject::ElementsAreSafeToExamine() {
- return (FLAG_use_gvn && FLAG_use_allocation_folding) ||
- reinterpret_cast<Map*>(elements()) !=
- GetHeap()->one_pointer_filler_map();
-}
bool DescriptorArray::IsSortedNoDuplicates(int valid_entries) {
=======================================
--- /branches/bleeding_edge/src/objects.h Fri Oct 25 20:42:51 2013 UTC
+++ /branches/bleeding_edge/src/objects.h Tue Oct 29 07:56:47 2013 UTC
@@ -2595,12 +2595,15 @@
};
void IncrementSpillStatistics(SpillInformation* info);
+#endif
+#ifdef VERIFY_HEAP
// If a GC was caused while constructing this object, the elements
pointer
// may point to a one pointer filler map. The object won't be rooted, but
// our heap verification code could stumble across it.
bool ElementsAreSafeToExamine();
#endif
+
Object* SlowReverseLookup(Object* value);
// Maximal number of fast properties for the JSObject. Used to
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
