Reviewers: machenbach,
Message:
This change requires https://codereview.chromium.org/47743007/ and
https://codereview.chromium.org/47023003/ to land before the tests will run
successfully with the --optimize-for-size flag.
PTAL.
Description:
Add --optimize_for_size to tests flag matrix.
BUG=None
Please review this at https://codereview.chromium.org/49633004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -1 lines):
M test/cctest/cctest.h
M tools/run-tests.py
Index: test/cctest/cctest.h
diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h
index
7f84c259f0c4cb1b135ae6a73d465d631d858e31..36621714153d0e81a9a7231aa0fe2402736b5006
100644
--- a/test/cctest/cctest.h
+++ b/test/cctest/cctest.h
@@ -324,7 +324,8 @@ static inline v8::Local<v8::Value>
CompileRunWithOrigin(const char* source,
// Pick a slightly different port to allow tests to be run in parallel.
static inline int FlagDependentPortOffset() {
return ::v8::internal::FLAG_crankshaft == false ? 100 :
- ::v8::internal::FLAG_always_opt ? 200 : 0;
+ ::v8::internal::FLAG_always_opt ? 200 :
+ ::v8::internal::FLAG_optimize_for_size ? 300 : 0;
}
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
dfe90368aed7c41a89286ce6515be51e8c56616e..f15fd4582a5725372a61d4ea77a47147bee7731a
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -54,6 +54,7 @@ TIMEOUT_SCALEFACTOR = {"debug" : 4,
# Use this to run several variants of the tests.
VARIANT_FLAGS = [[],
+ ["--optimize-for-size"],
["--stress-opt", "--always-opt"],
["--nocrankshaft"]]
MODE_FLAGS = {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
