On 2013/10/29 12:40:55, rmcilroy wrote:
https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/47023003/diff/1/src/arm/macro-assembler-arm.cc#newcode931
src/arm/macro-assembler-arm.cc:931: !isolate()->IsDebuggerActive()) {
On 2013/10/29 12:38:06, Benedikt Meurer wrote:
> Please add a new method to Isolate to determine whether code aging is
enabled,
> i.e. Isolate::IsCodeAgingActive().
Do you mean a new method to IsCodePreAgingActive()? (IsCodeAgingActive is trueif FLAG_age_code, it is the pre-aging that needs more checks)?
Yes. Just a method to encapsulate the sequence of checks that is currently duplicated for every architecture. IsCodePreAgingActive() sounds good. https://codereview.chromium.org/47023003/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
