Reviewers: Jakob, rmcilroy,

Message:
Please take a look. This change is needed to avoid breaking standalone builds of
V8 for Android after we land https://codereview.chromium.org/48113015/

Description:
Set arm_float_abi to softfp for standalone Android binary.

BUG=

Please review this at https://chromiumcodereview.appspot.com/46043015/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+2, -1 lines):
  M Makefile.android
  M build/android.gypi


Index: Makefile.android
diff --git a/Makefile.android b/Makefile.android
index 2d45d3bb122f9f4192227b1ab8d303ddf7b74297..d864beb1822016f7128ec18888b06758f3aa1970 100644
--- a/Makefile.android
+++ b/Makefile.android
@@ -98,5 +98,5 @@ $(ANDROID_MAKEFILES):
        CXX="${ANDROID_TOOLCHAIN}/bin/*-g++" \
        PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(PYTHONPATH)" \
        build/gyp/gyp --generator-output="${OUTDIR}" build/all.gyp \
-                     -Ibuild/standalone.gypi --depth=. -Ibuild/android.gypi \
+                     -Ibuild/android.gypi -Ibuild/standalone.gypi --depth=.  \
                      -S.${ARCH} ${GYPFLAGS}
Index: build/android.gypi
diff --git a/build/android.gypi b/build/android.gypi
index ca097255bbb5ce4deb018d5d95743af22af67b7c..0e5c73f3a55e93edce750ac67f695674c73dafde 100644
--- a/build/android.gypi
+++ b/build/android.gypi
@@ -67,6 +67,7 @@
     # Copy it out one scope.
     'android_webview_build%': '<(android_webview_build)',
     'OS': 'android',
+    'arm_float_abi': 'softfp',
   },  # variables
   'target_defaults': {
     'defines': [


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to